Fix: instance refresh missing properties #121
Conversation
|
@dotCipher, I am currently utilizing Error: starting Auto Scaling Group instance refresh:
ValidationError: 2 validation errors detected: Value '' at 'preferences.scaleInProtectedInstances' failed to satisfy constraint:
Member must satisfy enum value set: [Ignore, Wait, Refresh];
Value '' at 'preferences.standbyInstances' failed to satisfy constraint: Member must satisfy enum value set:
[Terminate, Ignore, Wait]Do you think this PR would fix the issue? |
|
@RoseSecurity I had the same issue. If you upgrade to v0.35.1 this should solve the issue you are having. But if you try to change any of the values from those properties it is not going to work. Their are set to the default that is "Ignore". This PR should fix that and allow you to change the values. |
|
@RoseSecurity I missed adding the values to the variables file but it is fixed now. I tested it by setting my fork as the source of the module and it works. Just FYI |
|
/terratest |
|
/terratest |
|
Thanks for the contribution! |
|
This change is not compatible with aws provider 4.x (it requires at least aws provider https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5160-september--8-2023 |
what
This PR adds two missing properties to the instance_refresh stanza.
why
Right now there is no way to configure scale_in_protected_instances and standby_instances in the instance refresh stanza.
references
This solves: #120